Unfriendly behavior of default theming functions with respect to title of 'street2' form field

Project: 
Ubercart
Category: 
feature request
Version: 
Ubercart 1.x-dev
Priority: 
minor
Assigned: 
Unassigned
Status: 
active

I think the default behavior with respect to 'street2' filed title in theme_uc_shipping_address() is unfriendly.

I feel that this somehow feeds into the questionable behavior of the uc_texfield function (http://api.ubercart.org/api/function/uc_textfield/1.0) with respect to empty field titles, as used by uc_checkout_pane_delivery (and it's cousin pane_billing).

It is understandable that in most cases it is preferred that 'street2' line is rendered w/o a label. Yet, it is frustrating to try to understand why, when leaving the label for 'street2' under '/admin/store/settings/checkout/edit/fields', the field is not rendered (despite being enabled); and when the label explicitly set, the field is rendered without one.

I don't know how to best address this issue -- perhaps through documentation. Can't call this a bug, so perhaps this is a feature request with respect to documentation.

the same applies to

the same applies to theme_address_pane() behavior

Re: the same applies to

Yeah... honestly, I'm not very proud of that theme function. Shocked

It's sloppy, and I'd happily take any recommendation into consideration to fix it up for D6.