delivery/billing address copy problem with zone

Project: 
Ubercart
Category: 
bug report
Version: 
Ubercart 1.3
Priority: 
normal
Assigned: 
Unassigned
Status: 
active

I bumped into this bug when I decided to check "my billing address is the same..." by default.

To reproduce the problem

0. Make Zone field required (the problem exists without this step but then it stays out of awareness)
1. Put something in the cart
2. Click checkout
3. Check "My billing information is the same as my delivery information." _before_ choosing delivery zone
4. Choose delivery zone and fill in at least all the required fields
5. submit form

What you should see now is "Zone field is required", because it hasn't been copied to the billing pane.

I widh I could include a patch but I'm still not familiar enough with JS/JQuery.

The bug also applies to the just-released 1.4 version

Thank you very much in helping with this one.

PS: Still wish to see a simple text field for Zone

Re: delivery/billing address copy problem with zone

Curious... I actually can't duplicate this on the Livetest. I'm using Firefox 3 on a Macbook.

It worked whether I used the address book feature or filled in all the address fields manually. Could it be you have old JS cached? Give it a shot on the Livetest and let me know if it works for you.

tryied

I've commented out all my code and problem still exists, so I believe it's in the core.

I can't reproduce it on the live test, and the only difference I've found (so far) is that in my shop the address defaults to Hungary, and I only have zones for US and Canada. So first I have to change the country to US and then choose a state. This is the way to reproduce.

BTW is it possible to change the default contry, or to set it to none (e.g. „choose country”)?

Thanks in advance

Tom Szigeti

Re: tryied

Do you have an example site for this I can test out?

Example

I have, but it's private, so I'm sending it to you in PM

Tom Szigeti

Re: Example

Ahh, I see Tom. It looks like it's happening when you don't select a country beforehand either. If I selected the country, then collapsed the panes, then selected a zone it worked just fine. But yeah, this does look to be a problem where it's not copying the zone select options down to the billing address. I'll see what I can do about a fix in the next release. Will post here if I get one soon.

That site looks incredible, by the way! Great job! Cool

thx

Thanx a lot! (:

Tom Szigeti

Re: thx

Hey Tom... finally got around to a patch. Can you try this out and let me know if it solves the issue for ya?

Diff is from the ubercart root directory. If it works for you, I'll commit it and port it to D6. It's working on the Livetest.

AttachmentSize
uc_cart_js.patch2.21 KB

tested

Hi, thanx for the patch, it solves the problem when entering delivery address manually, but if I'm logged in as a registered customer and choose a previously used delivery address from the dropdown list, than it says 'An illegal choice has been detected. Please contact the site administrator.', the billing zone is highlighted red and I see that the Billing country has not changed to the new delivery country.

Cheerz
Tom

Re: tested

After posting that patch, I found the issue you're describing and already committed this patch along w/ a patch for the second issue. Smiling